Skip to content

Revert #408 and update alb response annotation per #408's original intent #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 27, 2022
Merged

Revert #408 and update alb response annotation per #408's original intent #455

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3985733
Revert "Add `omitempty` to ALBTargetGroupRequest.Body (#408)"
bmoffatt Jul 13, 2022
19abe3c
update alb response struct per #408 intent
bmoffatt Jul 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions events/alb.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ type ALBTargetGroupRequest struct {
MultiValueHeaders map[string][]string `json:"multiValueHeaders,omitempty"`
RequestContext ALBTargetGroupRequestContext `json:"requestContext"`
IsBase64Encoded bool `json:"isBase64Encoded"`
Body string `json:"body,omitempty"`
Body string `json:"body"`
}

// ALBTargetGroupRequestContext contains the information to identify the load balancer invoking the lambda
Expand All @@ -29,6 +29,6 @@ type ALBTargetGroupResponse struct {
StatusDescription string `json:"statusDescription"`
Headers map[string]string `json:"headers"`
MultiValueHeaders map[string][]string `json:"multiValueHeaders"`
Body string `json:"body"`
Body string `json:"body,omitempty"`
IsBase64Encoded bool `json:"isBase64Encoded"`
}
3 changes: 2 additions & 1 deletion events/testdata/alb-lambda-target-request-headers-only.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,5 +21,6 @@
"x-imforwards": "20",
"x-myheader": "123"
},
"body": "",
"isBase64Encoded": false
}
}
4 changes: 2 additions & 2 deletions events/testdata/alb-lambda-target-request-multivalue-headers.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,6 @@
"123"
]
},
"body": "Some text",
"body": "",
"isBase64Encoded": false
}
}