Additional HTTP event and response objects. #320
Conversation
| Arguments.of("api_gateway_payload_format_v2_request.json", LambdaHTTPEvent.class), | ||
| Arguments.of("http_response.json", LambdaHTTPResponse.class) |
There was a problem hiding this comment.
These events should also be compatible with APIGatewayV2HTTPEvent and APIGatewayV2HTTPResponse correct? Could you please add those assertions in as well?
(nit: move these lines further up to preserve alphabetical ordering)
| @@ -0,0 +1,44 @@ | |||
| { | |||
There was a problem hiding this comment.
Why did you opt to name this file api_gateway_* v/s a more generic http_response for the response file?
There was a problem hiding this comment.
The docs for function urls specifically call out that the format is the same as Amazon API Gateway payload format version 2.0. So I thought that was a good name, given there are other very similar events.
|
For ref. here is the equivalent change in the Go lib: aws/aws-lambda-go#436 |
...-java-events/src/main/java/com/amazonaws/services/lambda/runtime/events/LambdaHTTPEvent.java
Outdated
Show resolved
Hide resolved
...va-events/src/main/java/com/amazonaws/services/lambda/runtime/events/LambdaHTTPResponse.java
Outdated
Show resolved
Hide resolved
|
After speaking to @bmoffatt I've changed the implementation to match the implementation written for Go. |
|
Tested on AWS |
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.