adding support for .cjs file extensions for user function #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Within ES modules (type is module inside package.json), if you try
to either:
```
require('file')
require('file.js')
```
it does not allow that as imports should be used within ES modules.
The only way to use require() is to explicitly require `.cjs` file
which explicitly insidicates that path is a CommonJS file, not ESM:
```
require('file.cjs')
```
This change allows to require .cjs files when a user function is being
searched. I would imagine eventually this library would need to fully
support ES modules as per
aws#44
however this diff will allow people to use lambdas within ES modules
if they have .cjs lambda files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Within ES modules (type is module inside package.json), if you try to either:
it does not allow that as imports should be used within ES modules. The only way to use require() is to explicitly require
.cjsfile which explicitly indicates that path is a CommonJS file, not ESM:Issue #, if available:
partly related to #44
Description of changes:
This change allows to require .cjs files when a user function is being searched. I would imagine eventually this library would need to fully support ES modules as per
#44 however this diff will allow people to use lambdas within ES modules if they have .cjs lambda files.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.