Skip to content

Fix CI for i686-pc-windows-gnu #809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 28, 2025
Merged

Conversation

justsmth
Copy link
Contributor

Issues:

Resolves #ISSUE-NUMBER1
Addresses #ISSUE-NUMBER2

Description of changes:

Describe current behavior and how your code changes that behavior. If there are no issues this pr is resolving, explain why this change is necessary.

Call-outs:

Point out areas that need special attention or support during the review process. Discuss architecture or design changes.

Testing:

How is this change tested (unit tests, fuzz tests, etc.)? Are there any testing steps to be verified by the reviewer?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@codecov-commenter
Copy link

codecov-commenter commented May 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.34%. Comparing base (c358484) to head (ae62a91).
Report is 218 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #809      +/-   ##
==========================================
- Coverage   95.80%   92.34%   -3.46%     
==========================================
  Files          61       71      +10     
  Lines        8143     8972     +829     
  Branches        0     8972    +8972     
==========================================
+ Hits         7801     8285     +484     
- Misses        342      418      +76     
- Partials        0      269     +269     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@justsmth justsmth force-pushed the fix-i686-pc-windows-gnu branch 5 times, most recently from a2d23b9 to a4c0cbb Compare May 12, 2025 19:43
@justsmth justsmth force-pushed the fix-i686-pc-windows-gnu branch from 68b6c55 to ae62a91 Compare May 12, 2025 20:00
@justsmth justsmth changed the title [DRAFT] Fix CI for i686-pc-windows-gnu Fix CI for i686-pc-windows-gnu May 12, 2025
@justsmth justsmth marked this pull request as ready for review May 12, 2025 20:08
@justsmth justsmth requested a review from a team as a code owner May 12, 2025 20:08
@justsmth justsmth requested a review from skmcgrail May 12, 2025 20:37
@justsmth justsmth merged commit e1206ed into aws:main May 28, 2025
287 checks passed
@justsmth justsmth deleted the fix-i686-pc-windows-gnu branch May 28, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants