Skip to content

How to send node label to webhook? #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
johnchenghk01 opened this issue Oct 16, 2020 · 1 comment · Fixed by #382
Closed

How to send node label to webhook? #265

johnchenghk01 opened this issue Oct 16, 2020 · 1 comment · Fixed by #382
Assignees
@imuqtadir
Labels
good first issue Good for newcomers Priority: Medium This issue will be seen by about half of users Status: Work in Progress Type: Enhancement New feature or request
Milestone
Webhook Enhancements

Comments

@johnchenghk01
Copy link

Is it able to send some node labels to the webhook?
@bwagner5
Copy link
Contributor

Currently no, NTH does not allow you to add node labels to the webhook template. I think this would require a fairly small change to make this possible though since we already fetch node label in the node pkg. We'd just need to join that info in the existing composite struct that the webhook template uses for data.

@bwagner5 bwagner5 added the Type: Enhancement New feature or request label Oct 16, 2020
@bwagner5 bwagner5 added the good first issue Good for newcomers label Jan 6, 2021
@bwagner5 bwagner5 mentioned this issue Jan 29, 2021
Closed
@jillmon jillmon added Status: Help Wanted Priority: Medium This issue will be seen by about half of users and removed Status: Help Wanted labels Feb 11, 2021
@jillmon jillmon added this to the Webhook Enhancements milestone Feb 11, 2021
@imuqtadir imuqtadir mentioned this issue Mar 2, 2021
Merged
@imuqtadir imuqtadir linked a pull request Mar 2, 2021 that will close this issue
Add node name to webhook template #379
Merged
@imuqtadir imuqtadir removed a link to a pull request Mar 2, 2021
Add node name to webhook template #379
Merged
@imuqtadir imuqtadir mentioned this issue Mar 5, 2021
Merged
@imuqtadir imuqtadir linked a pull request Mar 5, 2021 that will close this issue
Provide node labels for webhook template #382
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@imuqtadir imuqtadir

Labels
good first issue Good for newcomers Priority: Medium This issue will be seen by about half of users Status: Work in Progress Type: Enhancement New feature or request
Projects
None yet
Milestone
Webhook Enhancements
Development

Successfully merging a pull request may close this issue.

Provide node labels for webhook template imuqtadir/aws-node-termination-handler
4 participants
@bwagner5 @imuqtadir @johnchenghk01 @jillmon