-
Notifications
You must be signed in to change notification settings - Fork 271
Provide node labels for webhook template #382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it will be good once NodeLabels
is moved to interruptionEvent struct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made one little comment. But other than that it looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! nicely done
Issue #, if available: #265
Description of changes: The node labels would be provided for users to use however by default we will not be sending out node labels. The users can now provide their webhook template and display the all/desired labels.
Sample:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.