Skip to content

Invalid value: "webhookTemplate" #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
elliotdobson opened this issue Nov 27, 2020 · 2 comments
Closed

Invalid value: "webhookTemplate" #306

elliotdobson opened this issue Nov 27, 2020 · 2 comments

Comments

@elliotdobson
Copy link

Helm version: v3.4.0
Helm chart version: aws-node-termination-handler-0.13.0
App version: 1.11.0
Kubernetes version: 1.18.10

values.yaml

# image version
image:
  tag: v1.11.0

# Webhook URL will be fetched from the secret store using the given name.
webhookURLSecretName: "aws-node-termination-handler-slack-secret"

# webhook template file will be fetched from given config map name
# if specified, replaces the default webhook message with the content of the template file
webhookTemplateConfigMapName: "aws-node-termination-handler-slack-template"

# template file name stored in configmap
webhookTemplateConfigMapKey: "slack-template.json"

Install command:

helm install aws-node-termination-handler --namespace kube-system --values values.yaml eks/aws-node-termination-handler

When installing aws-node-termination-handler from the helm chart I am getting the following error:

Error: DaemonSet.apps "aws-node-termination-handler" is invalid: [spec.template.spec.volumes[1].name: Invalid value: "webhookTemplate": a DNS-1123 label must consist of lower case alphanumeric characters or '-', and must start and end with an alphanumeric character (e.g. 'my-name',  or '123-abc', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?'), spec.template.spec.containers[0].volumeMounts[1].name: Not found: "webhookTemplate"]

As the error suggest a volume name cannot contain an upper case character. If I output the helm output to yaml and change the webhookTemplate volume name so that it does not contain an upper case, it applies fine.

@bwagner5
Copy link
Contributor

I just merged the fix in for this #300 thanks to @n0gu ! We will get a release out soon.

@bwagner5 bwagner5 added the Pending-Release Pending an NTH or eks-charts release label Nov 27, 2020
@bwagner5
Copy link
Contributor

sorry for the delay, but v1.11.1 is released now!

@snay2 snay2 removed the Pending-Release Pending an NTH or eks-charts release label Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants