-
Notifications
You must be signed in to change notification settings - Fork 271
Fix volume name of daemonsets to follow DNS-1123 label standard #300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #300 +/- ##
=======================================
Coverage 74.76% 74.76%
=======================================
Files 17 17
Lines 1169 1169
=======================================
Hits 874 874
Misses 253 253
Partials 42 42 Continue to review full report at Codecov.
|
thanks for this! Can you update the chart version to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
up the chart version to 0.13.1
Sorry for the back-and-forth, you'll need to rebase the change too in order to resolve the chart version conflict. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like the template changes got reverted when you rebased
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
Description of changes:
When trying to use aws-node-termination-handler with
webhookTemplateConfigMapName
andwebhookTemplateConfigMapKey
configured, following error occurs:This PR fixes those names.
see also: aws/eks-charts#363
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.