Update ClusterRole to include 'get' for pods #391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwagner5
reviewed
Mar 26, 2021
config/helm/prometheus-operator/templates/prometheus-operator/clusterrole.yaml
Outdated
Show resolved
Hide resolved
bwagner5
approved these changes
Mar 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #355
Description of changes: Add permissions for 'get' to pod resources. This was causing eviction to fail internally while seeming to a successful eviction and mask all errors. After overriding the kubectl lib and adding logs (unfortunately, missing within the package), I found the error to be:
"spark-pi-driver" is forbidden: User "system:serviceaccount:kube-system:aws-node-termination-handler" cannot get resource "pods" in API group "" in the namespace "default"By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.