Skip to content

always do license check and use dockerhub for go-report-card image pulls #432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2021
Merged

always do license check and use dockerhub for go-report-card image pulls #432

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,9 @@ jobs:
- name: Lints
run: make spellcheck shellcheck helm-lint

- name: License Check
run: make license-test

- name: Go Report Card Tests
run: make go-report-card-test

Expand Down Expand Up @@ -128,9 +131,6 @@ jobs:
- name: Check out code into the Go module directory
uses: actions/checkout@v2

- name: License Check
run: make license-test

- name: Release Linux Assets
run: make release
env:
Expand Down
4 changes: 2 additions & 2 deletions test/go-report-card-test/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM public.ecr.aws/bitnami/golang:latest
FROM golang:latest

WORKDIR /app

Expand All @@ -12,4 +12,4 @@ RUN go get github.com/gojp/goreportcard/cmd/goreportcard-cli

RUN go get -u golang.org/x/tools/cmd/goimports

CMD $GOPATH/bin/goreportcard-cli -v -t 90
CMD $GOPATH/bin/goreportcard-cli -v -t 90
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this threshold not mean anything/can it be removed? It's set to 93 in the script itself and it seems to adhere to that than this param

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's the default threshold if you don't specify any command when calling docker run.