-
Notifications
You must be signed in to change notification settings - Fork 271
add imds asg target lifecycle hook #825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want this PR to never become stale, please ask a maintainer to apply the "stalebot-ignore" label. |
I have create issue as well to discuss/describe this PR - resolves #837 |
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want this PR to never become stale, please ask a maintainer to apply the "stalebot-ignore" label. |
any update on this? If it is not required, I can close the PR and issue. |
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want this PR to never become stale, please ask a maintainer to apply the "stalebot-ignore" label. |
This PR was closed because it has become stale with no activity. |
This would be super helpful! |
closing the PR as this change was included as part of another PR with e2e tests including your changes, once again thanks for working on the implementation :) |
Issue #, if available:
ASG target lifecycle hook is already available in instance metadata service. This pull request adds it to IMDS option.
Description of changes:
Adding ASG Termination Lifecycle Hook to IMDS Processor.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.