Support different header/lib install locations #1315
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, consumers will look for includes in the wrong directory if they set CMAKE_INSTALL_INCLUDEDIR to something other than "include" when installing.
The derivation of AWSSDK_ROOT_DIR from the include directory assumed that CMAKE_INSTALL_INCLUDEDIR is the default "include", and similarly for CMAKE_INSTALL_LIBDIR. Paths with more than one component are now supported, including absolute paths, though CMAKE_INSTALL_INCLUDEDIR and CMAKE_INSTALL_LIBDIR are still required to have a common root directory.
11 tasks
|
Greetings! Sorry to say but this is a very old issue that is probably not getting as much attention as it deservers. We encourage you to check if this is still an issue in the latest release and if you find that this is still a problem, please feel free to open a new one. |
github-actions
bot
added
closing-soon
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the SDK assumed that its headers would be installed into
<prefix>/includeand its libraries into<prefix>/<libdir>, wherelibdiris a single directory name. This change allows installing headers into<prefix>/<includedir>, and letslibdirandincludedirboth be complete paths instead of just directory names. In particular,<prefix>can be/andincludedirandlibdircan both be absolute paths.includedirandlibdirare given by the usualCMAKE_INSTALL_INCLUDEDIRandCMAKE_INSTALL_LIBDIR.This change is necessary to allow usage of the SDK with CMake on platforms where
CMAKE_INSTALL_INCLUDEDIRandCMAKE_INSTALL_LIBDIRare absolute paths, or even just contain more than one directory component. In particular it supports whenprefixis just/, such as with the Nix package manager (whereCMAKE_INSTALL_INCLUDEDIRis/nix/store/<some-hash>-aws-sdk-cpp/includeandCMAKE_INSTALL_LIBDIRis/nix/store/<some-other-hash>-aws-sdk-cpp-dev/lib, for example). It should also fix #1188.Sorry about the large number of touched files, every SDK component has the same boilerplate that needed fixing.
Note: This does not address any installation issues regarding automatically built dependencies (aws-c-common etc), the expectation is that if a user needs custom lib and include dirs like this then they will build the dependencies themselves.
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.