Build dev 1.10 pr11 #2028
Merged
Build dev 1.10 pr11 #2028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdavtaker
force-pushed
the
build-dev-1.10-pr11
branch
from
597a9f2 to
b89de25
Compare
sbiscigl
reviewed
Aug 10, 2022
| if (BUILD_TESTING) | ||
| message(STATUS "Building tests") | ||
| # Testing dependency | ||
| find_package(GTest 1.11 REQUIRED) |
There was a problem hiding this comment.
why not follow HEAD? from their page
GoogleTest now follows the Abseil Live at Head philosophy. We recommend [updating to the latest commit in the main branch as often as possible.
There was a problem hiding this comment.
Because we know what version works with our build at this particular version. If head is not backward compatible at some point tests of old versions of SDK will not work anymore.
sbiscigl
approved these changes
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1888 , if available:
Description of changes:
Added support for detecting and linking external dependencies to the build. Core and Core-Test build, but they do not work yet as expected. Sharing PR now since the diff is already too big. LEGACY_BUILD got broken because of issues finding CRT.
Next steps:
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.