build dev 1.10 pr12 #2041
Merged
build dev 1.10 pr12 #2041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbiscigl
approved these changes
Aug 18, 2022
|
please fix cspell and looks good |
Build fails from mixed use of types from CRT and SDK that was fixed after the creation of this branch. The rebase is going to be huge, so breaking the push in 2 steps befor continuing.
sdavtaker
force-pushed
the
build-dev-1.10-pr12
branch
from
16948cd to
a57ebb8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Issue #1888 *
Description of changes:
Changes to consume CRT form its own FindPackage construction available since 10.18.1, this BREAKs the build, need to rebase our branch to new version of SDK. I will do that in follow up PR.
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.