Protocol tests parsed response validation #3414
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeyRyabinin
added a commit
that referenced
this pull request
May 8, 2025
SergeyRyabinin
force-pushed
the
sr/pt/response
branch
from
1491dca to
ee87925
Compare
SergeyRyabinin
added a commit
that referenced
this pull request
May 9, 2025
SergeyRyabinin
force-pushed
the
sr/pt/response
branch
from
ee87925 to
2f031e3
Compare
SergeyRyabinin
added a commit
that referenced
this pull request
May 12, 2025
SergeyRyabinin
force-pushed
the
sr/pt/response
branch
from
2f031e3 to
98cd28b
Compare
SergeyRyabinin
force-pushed
the
sr/pt/response
branch
from
98cd28b to
605eb6b
Compare
sbiscigl
approved these changes
May 19, 2025
| else: # Unix-like | ||
| self.process.send_signal(signal.SIGINT) | ||
|
|
||
| time.sleep(0.5) |
There was a problem hiding this comment.
do we need static sleep? what are we waiting for?
| def wait(self): | ||
| """Wait for the subprocess to complete.""" | ||
| if self.process: | ||
| return self.process.wait() |
There was a problem hiding this comment.
waits without timeouts have heavily traumatized my up to this point, lets add a reasonable timeout to prevent zombie hosts
| .collect(Collectors.toSet()); | ||
| // include the request shapes | ||
| Set<String> requestShapes = testSuite.getCases().stream() | ||
| .map(entry -> { |
There was a problem hiding this comment.
looks like we only ever add one item to the set ever, simplified this could just be
testSuite.getCases().stream()
.map(entry -> { return String.format("<aws/%s/model/%s.h>",
serviceModel.getMetadata().getProjectName(),
entry.getGiven().getName() + "Request")})
.collect(Collectors.toSet());to avoid creating a extra set per test case
| #if(!$expectedResult.isEmpty()) | ||
| const ${responseShape.name}& result = outcome.GetResult(); | ||
| #end | ||
| /* expectedResult = R"( ${expectedResult} )" */ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Protocol tests
Description of changes:
Generate parsed response structure validation
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.