Skip to content

Update jmespath dependency version #2267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Update jmespath dependency version #2267

wants to merge 1 commit into from

Conversation

Hendra-Huang
Copy link

fixes #2266

@jasdel
Copy link
Contributor

jasdel commented Nov 16, 2018

Hi @Hendra-Huang thanks for creating this PR. Why was d6516e1 chosen instead of the most recent go-jmespath of c2b33e8?

@jasdel jasdel added the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Nov 16, 2018
@Hendra-Huang
Copy link
Author

Hi @jasdel , no strong reason for it. i just chose the version when the .gitignore issue is fixed.

@jasdel
Copy link
Contributor

jasdel commented Nov 19, 2018

Lets track this change in #2284, that PR updates the SDK to use the latest version of go-jmespath which includes the .gitignore.

@jasdel jasdel closed this Nov 19, 2018
@Hendra-Huang
Copy link
Author

okay. thanks

@diehlaws diehlaws removed the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"dep check" in CI always fail
3 participants
@Hendra-Huang @jasdel @diehlaws