aws/request: Fix SDK's handling of endpoints ending in slash #3926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasdel
force-pushed
the
fixup/TrailingSlash
branch
from
f7b0282 to
acb0008
Compare
skotambkar
reviewed
May 27, 2021
Fixes the SDK's handling of endpoints that end in a slash (`/`) causing signature validation errors due to Request.HTTPRequest.URL.Path not matching what was sent in the request. Squashes the duplicate slash character between endpoint's path and operation path.
jasdel
force-pushed
the
fixup/TrailingSlash
branch
from
acb0008 to
424b8c1
Compare
skotambkar
approved these changes
May 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the SDK's handling of endpoints that end in a slash (
/) causingsignature validation errors due to Request.HTTPRequest.URL.Path not
matching what was sent in the request.
Squashes the duplicate slash character between endpoint's path and
operation path.