-
Notifications
You must be signed in to change notification settings - Fork 893
Add more connection TTL options to the Netty HTTP client #856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@millems is there a way to set the connection TTL on an async client without these functions? |
These settings may or may not make sense for a NIO client. If a channel goes inactive it will remove itself from the pool as far as I know. Compare that to blocking IO where a connection may go inactive but we won't know that until the next time we use it, resulting in a failed request. Connection TTL makes sense for both. We should confirm the inactive behavior of channel before implementing the max idle, validate after inactivity, and idle reaper in NIO. @Eyal-Shalev there is not a way to set connection TTL currently. |
1. Added support for `useIdleConnectionReaper`, `connectionTimeToLive` and `connectionMaxIdleTime` to the Netty HTTP client. 2. Enable the idle connection reaper by default for apache and netty clients. Connection time-to-live remains disabled by default. Fixes #856
1. Added support for `useIdleConnectionReaper`, `connectionTimeToLive` and `connectionMaxIdleTime` to the Netty HTTP client. 2. Enable the idle connection reaper by default for apache and netty clients. Connection time-to-live remains disabled by default. Fixes #856
…9238122b Pull request: release <- staging/ded8419e-b232-4779-9b6e-6acb9238122b
I don't think this is true. I'm having some issues with some code trying to call SageMaker with a long The code worked fine on v1, but on v2 I notice that, if I make a request, wait ~1 minute and perform another request, I get an error:
I assume that this is caused by SageMaker closing the connection, which is never revalidated and ends up being reused. |
Missing feature matrix:
The text was updated successfully, but these errors were encountered: