Skip to content

Implement equals,hashCode on ExecutionAttributes #2457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 5, 2021

Conversation

dagnir
Copy link
Contributor

@dagnir dagnir commented May 4, 2021

Description

Motivation and Context

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@dagnir dagnir force-pushed the equals-executionattributes branch 2 times, most recently from 83cd5fc to a1621e9 Compare May 4, 2021 19:13
@dagnir dagnir force-pushed the equals-executionattributes branch from a1621e9 to 7dba2d6 Compare May 4, 2021 19:42
@dagnir
Copy link
Contributor Author

dagnir commented May 4, 2021

@codecov-commenter
Copy link

codecov-commenter commented May 4, 2021

Codecov Report

Merging #2457 (7dba2d6) into master (a5afc3c) will decrease coverage by 0.00%.
The diff coverage is 42.85%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2457      +/-   ##
============================================
- Coverage     77.72%   77.72%   -0.01%     
  Complexity      366      366              
============================================
  Files          1247     1247              
  Lines         39497    39504       +7     
  Branches       3090     3092       +2     
============================================
+ Hits          30701    30703       +2     
- Misses         7312     7314       +2     
- Partials       1484     1487       +3     
Flag Coverage Δ Complexity Δ
unittests 77.72% <42.85%> (-0.01%) 366.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...n/awssdk/core/interceptor/ExecutionAttributes.java 89.74% <42.85%> (-10.26%) 0.00 <0.00> (ø)
...nio/netty/internal/OldConnectionReaperHandler.java 81.81% <0.00%> (-9.10%) 0.00% <0.00%> (ø%)
...ty/internal/IdleConnectionCountingChannelPool.java 87.80% <0.00%> (+2.43%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5afc3c...7dba2d6. Read the comment docs.

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 5, 2021

@dagnir dagnir merged commit 281b1de into aws:master May 5, 2021
@dagnir dagnir deleted the equals-executionattributes branch May 5, 2021 18:21
aws-sdk-java-automation added a commit that referenced this pull request Apr 13, 2023
…275303a17

Pull request: release <- staging/660ee603-1d3d-48c6-9994-bbe275303a17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants