Improve Javadoc for request-level timeout #3771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
millems
reviewed
Feb 17, 2023
Comment on lines
127
to
129
| * <p> | ||
| * This will override the {@link ClientOverrideConfiguration#apiCallAttemptTimeout()} if it is configured. | ||
| * |
There was a problem hiding this comment.
Should this be added to the builder's setters as well? People are more likely to read the javadoc on the method they're calling (on the builder) instead of the method that the SDK is using (on the override configuration).
There was a problem hiding this comment.
Ah yeah, I thought I did, will update
millems
approved these changes
Feb 21, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
aws-sdk-java-automation
added a commit
that referenced
this pull request
Mar 26, 2025
…659a77518 Pull request: release <- staging/cdd54d63-df61-4cbd-99e3-a06659a77518
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Improve Javadoc for request-level timeout