Skip to content

fix wrong Source Control url in sonatype #3872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 31, 2023
Merged

fix wrong Source Control url in sonatype #3872

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0487514
fix wrong Source Control url in sonatype
L-Applin Mar 30, 2023
760f5f1
point to release branch instead of master
L-Applin Mar 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@
<module>test/ruleset-testing-core</module>
</modules>
<scm>
<url>https://github.com/aws/aws-sdk-java-v2.git</url>
<url>${scm.github.url}</url>
</scm>
<properties>
<awsjavasdk.version>${project.version}</awsjavasdk.version>
Expand Down Expand Up @@ -173,6 +173,7 @@
<skip.unit.tests>${skipTests}</skip.unit.tests>
<integTestSourceDirectory>${project.basedir}/src/it/java</integTestSourceDirectory>
<javadoc.resourcesDir>${session.executionRootDirectory}</javadoc.resourcesDir>
<scm.github.url>https://github.com/aws/aws-sdk-java-v2.git</scm.github.url>
</properties>

<dependencyManagement>
Expand Down Expand Up @@ -691,6 +692,9 @@

<profile>
<id>publishing</id>
<properties>
<scm.github.url>https://github.com/aws/aws-sdk-java-v2/tree/master</scm.github.url>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this work? <scm.github.url>${scm.github.url}</scm.github.url>

Copy link
Contributor Author

@L-Applin L-Applin Mar 30, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, because we need to override the property used in the <scm> tag

Copy link
Contributor

@millems millems Mar 30, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just do https://github.com/aws/aws-sdk-java-v2 in case we change our main branch name for inclusivity reasons later?

Edit: Nvm, I see it's a specific branch. Should we use the release branch, since that's what we release?

https://github.com/aws/aws-sdk-java-v2/tree/release

</properties>
<build>
<plugins>
<plugin>
Expand Down