-
Notifications
You must be signed in to change notification settings - Fork 894
fix(CopySourceRequestInS3): Updated codegen to customize the request before calling service #5244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
3bf3f76
fix(CopySourceRequestInS3): Updated codegen to customize the request …
joviegas 1a50677
Handle review comments
joviegas 0bfa19d
Handle review comments 2
joviegas e95ec08
Handle review comments 3
joviegas fe0943b
Merge branch 'master' into joviegas/api_prepare_request
joviegas 96a4aa1
Added change log
joviegas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
65 changes: 65 additions & 0 deletions
65
.../src/main/java/software/amazon/awssdk/codegen/model/service/CustomRequestTransformer.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,65 @@ | ||
/* | ||
* Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"). | ||
* You may not use this file except in compliance with the License. | ||
* A copy of the License is located at | ||
* | ||
* http://aws.amazon.com/apache2.0 | ||
* | ||
* or in the "license" file accompanying this file. This file is distributed | ||
* on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either | ||
* express or implied. See the License for the specific language governing | ||
* permissions and limitations under the License. | ||
*/ | ||
|
||
package software.amazon.awssdk.codegen.model.service; | ||
|
||
/** | ||
* Represents a custom request transformer for API requests. | ||
* | ||
* <p>This class allows for dynamic and specific transformation of API requests, | ||
* ensuring that each request is appropriately transformed based on the | ||
* transformation logic defined in the specified {@link CustomRequestTransformer#getClassName()} and | ||
* {@link CustomRequestTransformer#getMethodName()}. | ||
* | ||
* <p>Example: | ||
* <pre> | ||
* { | ||
* "methodName": "dummyRequestModifier", | ||
* "className": "software.amazon.awssdk.codegen.internal.UtilsTest" | ||
* } | ||
* </pre> | ||
* | ||
* <p>The class should have a public static method dummyRequestModifier | ||
* that takes an input and returns an output of ApiRequest for which Customization is applied. | ||
*/ | ||
|
||
public class CustomRequestTransformer { | ||
|
||
/** | ||
* The fully qualified name of the class that defines the transformation method. The {@code methodName} is the | ||
*/ | ||
private String className; | ||
|
||
/** | ||
* The name of the method within that class which will perform the transformation | ||
*/ | ||
private String methodName; | ||
|
||
public String getClassName() { | ||
return className; | ||
} | ||
|
||
public void setClassName(String className) { | ||
this.className = className; | ||
} | ||
|
||
public String getMethodName() { | ||
return methodName; | ||
} | ||
|
||
public void setMethodName(String methodName) { | ||
this.methodName = methodName; | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I would drop the
map
suffix (everything is a map in json), simplycustomRequestTransformers
sounds more clear to me. Other keys, likecustomOperationContextParams
don't have the map suffix, it would make the customization file more consistent. But it is not a blocker for me.