-
Notifications
You must be signed in to change notification settings - Fork 889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flaky integ test where the SubscribeToShardIntegrationTest #5949
Flaky integ test where the SubscribeToShardIntegrationTest #5949
Conversation
asyncClient.listShards(r -> r.streamName(streamName)).join(); | ||
return true; | ||
} catch (Exception e) { | ||
if (e.getCause() instanceof ResourceInUseException) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already have a Waiter waiting for the ACTIVE
state, but we are failing because the stream is in the CREATING
stage? That seems weird, are we sure this is helping?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeap , I have attached the complete log in the internal issue.
The above log is taken from the codebuild logs.
I have started Integ test too as part of the codebuild
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The additional check will ensure that the actual state is properly reflected in the system and will provide additional time with retry logic rather than immediately failing(same as we retrying the test case when it fails)
I recommend proceeding with this safe approach since the current failure of this test case is unnecessarily blocking the release and creating significant churn.
|
Motivation and Context
Modifications
License