Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding additional wait to avoid eventual consistency issues #6006

Merged
merged 1 commit into from
Apr 7, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
import software.amazon.awssdk.services.kinesis.model.ConsumerStatus;
import software.amazon.awssdk.services.kinesis.model.PutRecordRequest;
import software.amazon.awssdk.services.kinesis.model.Record;
import software.amazon.awssdk.services.kinesis.model.ResourceInUseException;
import software.amazon.awssdk.services.kinesis.model.Shard;
import software.amazon.awssdk.services.kinesis.model.ShardIteratorType;
import software.amazon.awssdk.services.kinesis.model.StreamStatus;
Expand Down Expand Up @@ -202,6 +203,21 @@ private void waitForStreamToBeActive() {
.join())
.until(b -> b.streamDescription().streamStatus().equals(StreamStatus.ACTIVE))
.orFailAfter(Duration.ofMinutes(5));

// Additional verification to ensure stream is fully operational
Waiter.run(() -> {
try {
asyncClient.listShards(r -> r.streamName(streamName)).join();
return true;
} catch (Exception e) {
if (e.getCause() instanceof ResourceInUseException) {
return false;
}
throw e;
}
})
.until(Boolean::booleanValue)
.orFailAfter(Duration.ofMinutes(1));
}

private void waitForConsumersToBeActive() {
Expand Down
Loading