Skip to content

Feature/credential provider env #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 23, 2017
Merged

Feature/credential provider env #24

merged 2 commits into from
Jun 23, 2017

Conversation

jeskew
Copy link
Contributor

@jeskew jeskew commented Jun 13, 2017 •
edited
Loading

Spun off from #5

This PR adds a credential provider that reads from AWS_ACCESS_KEY_ID, AWS_SECRET_ACCESS_KEY, and AWS_SESSION_TOKEN.

@jeskew jeskew requested review from awood45 and chrisradek June 13, 2017 22:11
@jeskew jeskew mentioned this pull request Jun 13, 2017
Closed
5 tasks
chrisradek
chrisradek reviewed Jun 20, 2017
View reviewed changes
Copy link
Contributor

@chrisradek chrisradek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think some SDKs also support setting the expiry time for environment credentials.
https://code.amazon.com/packages/AwsDrSeps/blobs/master/--/seps/accepted/shared/refreshing-credentials.md

This was specifically asked for by Lambda, since they can change the environment variables in the process object while the function is running.

@jeskew
Copy link
Contributor Author

jeskew commented Jun 20, 2017

I didn't realize that SEP had been accepted, but it looks like Boto has implemented it. Is this something we should think about adding to V2?

@chrisradek
Copy link
Contributor

I believe we have it on our backlog for V2 :)

chrisradek
chrisradek approved these changes Jun 23, 2017
View reviewed changes
Copy link
Contributor

@chrisradek chrisradek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@jeskew jeskew merged commit 6eb0c29 into aws:master Jun 23, 2017
@jeskew jeskew deleted the feature/credential-provider-env branch June 23, 2017 19:00
trivikr referenced this pull request in trivikr/aws-sdk-js-v3 Dec 10, 2018
@jeskew
Merge pull request #24 from jeskew/feature/credential-provider-env
6dddf93 
Feature/credential provider env
@lock
Copy link

lock bot commented Sep 26, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chrisradek chrisradek chrisradek approved these changes

@awood45 awood45 Awaiting requested review from awood45

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeskew @chrisradek