chore(codegen): pin smithy to 1.9.x #2529
Conversation
| * @returns The value as a number, undefined if it's null/undefined, | ||
| * otherwise an error is thrown. | ||
| */ | ||
| export const handleFloat = (value: string | number): number | undefined => { |
There was a problem hiding this comment.
parseFloat, like parseBoolean above?
There was a problem hiding this comment.
parseFloat is a built in function
JordonPhillips
force-pushed
the
update-smithy-1-9
branch
from
474892c to
a440491
Compare
Codecov Report
@@ Coverage Diff @@
## main #2529 +/- ##
=======================================
Coverage ? 60.24%
=======================================
Files ? 513
Lines ? 27359
Branches ? 6421
=======================================
Hits ? 16482
Misses ? 10877
Partials ? 0 Continue to review full report at Codecov.
|
|
Just an FYI: the java bits will fail until smithy-lang/smithy-typescript#367 is merged because it includes a fix to the test generators. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
trivikr
changed the title
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Issue
Follow-up to #2499
Smithy 1.9.0 release https://github.com/awslabs/smithy/releases/tag/1.9.0
Description
This updates the generators to 1.9.x and adds support for non-numeric float values. I also noticed that tests for AWS JSON 1.0 weren't being generated, so I added those in.
Testing
Protocol tests were generated and run.
Additional context
This relies on smithy-lang/smithy-typescript#367
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.