-
Notifications
You must be signed in to change notification settings - Fork 612
feat(scripts): use esprint to eslint --fix clients source code #2846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2846 +/- ##
=======================================
Coverage 60.42% 60.42%
=======================================
Files 554 554
Lines 28886 28886
Branches 7072 7072
=======================================
Hits 17453 17453
Misses 11433 11433 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally we can lint our generated clients! Just remove the extra comment
76a8164
to
481feba
Compare
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Issue
Follow-up to #2838 which ran eslint in series.
This PR will be made ready for review after source code is moved to src folder in #2845PR is readyDescription
Adds script to
eslint --fix
clients source code in parallelBefore
After
Testing
Verified that source code is linted in #2849
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.