chore(dependency): bump aws crypto helpers dependency to 2.0.0 #2940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We pinned to 2.0.0 because crypto helpers 2.0.0+ is suppose to drop support for Node.js 10. They may introduce warnings or breaking change in any time. We should unpin the version after v3 drops the support for Node.js 10 too.
Codecov Report
@@ Coverage Diff @@
## main #2940 +/- ##
=======================================
Coverage 58.57% 58.57%
=======================================
Files 558 558
Lines 30248 30248
Branches 7443 7443
=======================================
Hits 17718 17718
Misses 12530 12530 Continue to review full report at Codecov.
|
trivikr
approved these changes
Oct 27, 2021
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We pinned to 2.0.0 because crypto helpers 2.0.0+ is suppose to drop
support for Node.js 10. They may introduce warnings or breaking change
in any time. We should unpin the version after v3 drops the support
for Node.js 10 too.
Issue
Resolves: #2810
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.