Skip to content

[WIP] feat(config-resolver): resolve hostname from variants #2972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 25 commits into from

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Nov 2, 2021

Issue

Internal JS-2929

Description

Uses variants for getting region info

  • resolveRegionConfig converts legacy pseudo regions to real regions, and sets isFipsReigon is required.
  • getRegionInfo processes variants if ifFipsEndpoint or isDualstackEndpoint is set.

Testing

  • Unit testing
  • Functional testing

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2021

Codecov Report

Merging #2972 (9b1c2bb) into main (0dd68ef) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2972      +/-   ##
==========================================
+ Coverage   58.70%   58.72%   +0.02%     
==========================================
  Files         566      566              
  Lines       30315    30330      +15     
  Branches     7460     7469       +9     
==========================================
+ Hits        17796    17811      +15     
  Misses      12519    12519              
Impacted Files Coverage Δ
...resolver/src/regionInfo/getHostnameFromVariants.ts 100.00% <100.00%> (ø)
...es/config-resolver/src/regionInfo/getRegionInfo.ts 100.00% <100.00%> (ø)
...fig-resolver/src/regionInfo/getResolvedHostname.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0dd68ef...9b1c2bb. Read the comment docs.

@trivikr trivikr force-pushed the get-region-info-from-variants-dev branch from d0787b5 to e97036c Compare November 2, 2021 21:05
@trivikr trivikr changed the base branch from populate-variants-endpoint-hashes to populate-variants-endpoint-hashes-final November 2, 2021 21:05
@trivikr trivikr changed the title chore(config-resolver): use variants for getting region info feat(config-resolver): resolve hostname from variants Nov 2, 2021
@trivikr trivikr force-pushed the get-region-info-from-variants-dev branch from 0eb24ed to 7f75540 Compare November 3, 2021 13:59
@trivikr trivikr changed the base branch from populate-variants-endpoint-hashes-final to main November 3, 2021 13:59
@trivikr trivikr changed the title feat(config-resolver): resolve hostname from variants [WIP] feat(config-resolver): resolve hostname from variants Nov 3, 2021
@trivikr
Copy link
Member Author

trivikr commented Nov 3, 2021

Superceded by #2980

@trivikr trivikr closed this Nov 3, 2021
@trivikr trivikr deleted the get-region-info-from-variants-dev branch November 3, 2021 22:45
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants