Skip to content

chore: pass fips/dualstack config to regionInfoProvider #2982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Nov 4, 2021

Issue

PR for follow-up to #2980

Description

Passes fips/dualstack configuration while resolving regionInfo from following packages:

  • config-resolver
  • middleware-bucket-endpoint
  • middleware-sdk-s3-control
  • middleware-signing

Testing

  • CI
  • Integration tests

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2021

Codecov Report

Merging #2982 (66e4238) into main (447580b) will increase coverage by 0.01%.
The diff coverage is 95.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2982      +/-   ##
==========================================
+ Coverage   58.72%   58.73%   +0.01%     
==========================================
  Files         566      566              
  Lines       30330    30341      +11     
  Branches     7469     7472       +3     
==========================================
+ Hits        17811    17821      +10     
- Misses      12519    12520       +1     
Impacted Files Coverage Δ
...s/middleware-bucket-endpoint/src/configurations.ts 91.66% <ø> (ø)
packages/middleware-signing/src/configurations.ts 88.00% <83.33%> (-0.89%) ⬇️
...lver/src/endpointsConfig/resolveEndpointsConfig.ts 100.00% <100.00%> (ø)
...src/endpointsConfig/utils/getEndpointFromRegion.ts 100.00% <100.00%> (ø)
...re-bucket-endpoint/src/bucketEndpointMiddleware.ts 93.47% <100.00%> (+0.29%) ⬆️
.../process-arnables-plugin/parse-outpost-arnables.ts 96.82% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 447580b...66e4238. Read the comment docs.

@trivikr trivikr changed the title [WIP] chore: pass fips/dualstack config while resolving regionInfo [WIP] chore: pass fips/dualstack config to regionInfoProvider Nov 4, 2021
@trivikr trivikr force-pushed the pass-fips-dualstack-config-regionInfoProvider-dev branch from 39ca5dc to b0101e5 Compare November 4, 2021 04:39
@trivikr trivikr changed the base branch from get-region-info-from-variants to main November 4, 2021 04:39
@trivikr trivikr marked this pull request as ready for review November 4, 2021 04:39
@trivikr trivikr requested a review from AllanZhengYP November 4, 2021 04:40
@trivikr trivikr changed the title [WIP] chore: pass fips/dualstack config to regionInfoProvider chore: pass fips/dualstack config to regionInfoProvider Nov 4, 2021
@trivikr trivikr merged commit 45365ac into aws:main Nov 4, 2021
@trivikr trivikr deleted the pass-fips-dualstack-config-regionInfoProvider-dev branch November 4, 2021 16:58
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants