Skip to content

Add a default credential provider package for use in Node applications #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2017
Merged

Add a default credential provider package for use in Node applications #30

merged 1 commit into from
Jun 30, 2017

Conversation

jeskew
Copy link
Contributor

@jeskew jeskew commented Jun 28, 2017

This PR adds a default credential provider that follows the standard SDK lookup pattern. Since chaining, caching, and each individual provider is defined outside of this package, the PR includes ~7 lines of code, ~20 lines of documentation, and ~225 lines of tests.

@jeskew jeskew requested review from awood45 and chrisradek June 28, 2017 19:29
@jeskew jeskew mentioned this pull request Jun 28, 2017
5 tasks
Copy link
Contributor

@chrisradek chrisradek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, ship it!

@jeskew jeskew merged commit 1b0080d into aws:master Jun 30, 2017
@jeskew jeskew deleted the feature/default-provider-chain branch June 30, 2017 21:32
trivikr referenced this pull request in trivikr/aws-sdk-js-v3 Dec 10, 2018
Add a default credential provider package for use in Node applications
@lock
Copy link

lock bot commented Sep 26, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants