Skip to content

feat: use common TSConfig for clients #3132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jan 4, 2022

Issue

Refs: #1307
Replaces: #2872

Description

Uses common TSConfig for all generated clients

Testing

CI

Additional context

This PR will be made ready after #3130 is merged.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

foreach parentDir ("clients" "private")
  for dir in ./$parentDir/*; do (cd "$dir" && sed -i 's/tsconfig.json/tsconfig.cjs.json/g' ./package.json); done
  for dir in ./$parentDir/*; do (cd "$dir" && mv tsconfig.json tsconfig.cjs.json); done
end
foreach parentDir ("clients" "private")
  foreach tsConfigType ("cjs" "es" "types")
    for dir in ./$parentDir/*; do (
      cd "$dir"
      cp ../../clients/client-accessanalyzer/tsconfig.$tsConfigType.json tsconfig.$tsConfigType.json
    ); done
  end
end
@trivikr
Copy link
Member Author

trivikr commented Jan 5, 2022

Superceded by #3145

@trivikr trivikr closed this Jan 5, 2022
@trivikr trivikr deleted the clients-root-tsconfig branch January 5, 2022 21:01
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant