Skip to content

chore(types): move profile types from other packages #3414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 14, 2022

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Mar 11, 2022

Issue

Internal JS-3150

The profile types are used across packages, and will be used in new package being introduced in JS-3150

Description

Moves profile types from shared-ini-file-loader to types package

Testing

CI


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr requested a review from a team as a code owner March 11, 2022 22:21
@trivikr trivikr changed the title chore(types): move profile type to types package chore(types): move profile types from other packages Mar 11, 2022
@trivikr trivikr requested a review from AllanZhengYP March 11, 2022 23:24
@trivikr trivikr merged commit ad6890d into aws:main Mar 14, 2022
@trivikr trivikr deleted the move-profile-type-to-types branch March 14, 2022 16:08
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants