Skip to content

chore(property-provider): extend CredentialsProviderError from ProviderError #3438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 16, 2022

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Mar 16, 2022

Issue

Internal JS-3150

We're going to introduce new ProviderErrors in future.

Description

Un-deprecates ProviderError and extends CredentialsProviderError from it.

Testing

Unit testing


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr requested a review from a team as a code owner March 16, 2022 15:53
@trivikr trivikr marked this pull request as draft March 16, 2022 15:55
@trivikr trivikr marked this pull request as ready for review March 16, 2022 16:10
@trivikr trivikr marked this pull request as draft March 16, 2022 16:12
@trivikr
Copy link
Member Author

trivikr commented Mar 16, 2022

The CI was not run due to ongoing incident with GitHub Actions, Codespaces, Issues, and Webhooks
https://www.githubstatus.com/incidents/fpk08rxnqjz2

@trivikr trivikr marked this pull request as ready for review March 16, 2022 17:17
@trivikr trivikr requested a review from AllanZhengYP March 16, 2022 17:18
@trivikr trivikr merged commit c2e7f6f into aws:main Mar 16, 2022
@trivikr trivikr deleted the extend-from-provider-error branch March 16, 2022 17:33
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants