Skip to content

feat: deserialize with error header #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 2, 2019

Conversation

srchase
Copy link
Contributor

@srchase srchase commented Oct 2, 2019

Deserialize errors using x-amzn-TypeError header instead of status code.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-io
Copy link

codecov-io commented Oct 2, 2019

Codecov Report

Merging #385 into smithy-codegen will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           smithy-codegen     #385   +/-   ##
===============================================
  Coverage           97.28%   97.28%           
===============================================
  Files                  69       69           
  Lines                1177     1177           
  Branches              215      215           
===============================================
  Hits                 1145     1145           
  Misses                 32       32

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b77246...02fb1f0. Read the comment docs.

@AllanZhengYP AllanZhengYP added the smithy-codegen Changes regarding supporting smithy model. Will be merged to smithy-codegen branch label Oct 2, 2019
@srchase srchase merged commit c8f5a3a into aws:smithy-codegen Oct 2, 2019
@srchase srchase deleted the fix-error-deserializer branch October 4, 2019 16:18
@lock
Copy link

lock bot commented Oct 11, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
smithy-codegen Changes regarding supporting smithy model. Will be merged to smithy-codegen branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants