Skip to content

Sets a default value for maxSockets of 50 when the https.globalAgent.maxSockets is set to Infinity. #1057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 13, 2016
Merged

Sets a default value for maxSockets of 50 when the https.globalAgent.maxSockets is set to Infinity. #1057

merged 1 commit into from
Jul 13, 2016

Conversation

chrisradek
Copy link
Contributor

This is a performance tuning change. With node.js 0.10 and lower, the default maxSockets on the global agent was 5, but later versions of node.js sets this to Infinity.

/cc @LiuJoyceC

@chrisradek
Sets a default value for maxSockets of 50 when the https.globalAgent.…
ea548f2 
…maxSockets is set to Infinity.

This is a performance tuning change. With node.js 0.10 and lower, the default maxSockets on the global agent was 5, but later versions of node.js sets this to Infinity.
@coveralls
Copy link

coveralls commented Jul 13, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-0.2%) to 88.838% when pulling ea548f2 on chrisradek:default/maxSockets into 9787eaa on aws:master.

@LiuJoyceC
Copy link
Contributor

🚀

@chrisradek chrisradek merged commit 4b70b26 into aws:master Jul 13, 2016
@chrisradek chrisradek deleted the default/maxSockets branch July 13, 2016 19:43
LiuJoyceC added a commit that referenced this pull request Jul 13, 2016
@LiuJoyceC
Tag release v2.4.7
d61f325 
References:
  #1057, #1058
LiuJoyceC added a commit that referenced this pull request Jul 26, 2016
@LiuJoyceC
Tag release v2.4.10
155bf58 
References:
  #1020, #1045, #1048, #1052, #1054, #1057, #1058, #1059,
  #1067
LiuJoyceC added a commit that referenced this pull request Jul 29, 2016
@LiuJoyceC
Tag release v2.4.11
11c8d80 
References:
  #1020, #1045, #1048, #1052, #1054, #1057, #1058, #1059,
  #1067, #1074, #1077
@lock
Copy link

lock bot commented Sep 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@LiuJoyceC LiuJoyceC

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chrisradek @coveralls @LiuJoyceC