Skip to content

Stop iteration on Request.eachitem returning false #1078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2016

Conversation

wryun
Copy link
Contributor

@wryun wryun commented Jul 27, 2016

This echoes the behaviour of eachPage.

This echoes the behaviour of eachPage.
@coveralls
Copy link

coveralls commented Jul 27, 2016

Coverage Status

Coverage increased (+0.01%) to 88.822% when pulling 4f5a7f1 on wryun:terminate-eachitem into f084bb0 on aws:master.

@wryun
Copy link
Contributor Author

wryun commented Jul 27, 2016

Not clear to me why build failed (only on Node 4.2). Seems unrelated:
https://travis-ci.org/aws/aws-sdk-js/jobs/147840412

@chrisradek
Copy link
Contributor

@wryun
Thanks for submitting a PR!
Sometimes the coveralls step fails even though the tests pass. Rerunning that step now.

@wryun
Copy link
Contributor Author

wryun commented Aug 16, 2016

Hey, is there anything I can do to encourage this to be merged? ;)

@chrisradek
Copy link
Contributor

@wryun
I'll take a look at this today or tomorrow. A quick cursory look, I don't see any issues with it. Since the docs call out eachItem as being an experimental feature, it's safe to make this change.

@chrisradek
Copy link
Contributor

@wryun
Thanks for the contribution! Changes look good, merging now so it'll be included with the next release!

@chrisradek chrisradek merged commit d49fb20 into aws:master Aug 18, 2016
LiuJoyceC added a commit that referenced this pull request Aug 18, 2016
@wryun
Copy link
Contributor Author

wryun commented Aug 19, 2016

Great, thanks! Appreciate it.

LiuJoyceC added a commit that referenced this pull request Aug 23, 2016
LiuJoyceC added a commit that referenced this pull request Aug 30, 2016
@lock
Copy link

lock bot commented Sep 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants