Skip to content

Feature request: support placeholders in the data parameter of TrainingStep constructor #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lucaboulard opened this issue Oct 12, 2020 · 1 comment

Comments

@lucaboulard
Copy link

Currently the data parameter to the TrainingStep constructor does not support placeholders, requiring the s3 location of the dataset to be known at workflow creation time.
It would be useful for this parameter to accept dynamic s3 uri, via placeholders.

shivlaks pushed a commit that referenced this issue Jun 19, 2021
…n for InputDataConfig and OutputDataConfig (#142)

Currently, it is not possible to specify the output path to TrainingStep. It needs to be defined at the Estimator level, which does not support placeholders. This change will make it possible to insert a placeholder output path from the TrainingStep definition and propagate it dynamically to the Estimator.

This change change also makes the TrainingStep data parameter compatible with placeholders.

There are other feature requests to make other TrainingStep arguments and ProcessingStep arguments compatible with placeholders. They will be addressed in a separate PR where the implementation could maybe be done at a higher level to avoid repetition.

Closes  #98 #97 #80
@shivlaks
Copy link
Contributor

Implemented in #142 which has now been merged 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants