Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Support placeholders for input_path and output_path for all States (except Fail) and items_path for MapState #158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: Support placeholders for input_path and output_path for all States (except Fail) and items_path for MapState #158
Changes from 2 commits
f5800cb
788c148
c975274
d20a883
1c397df
ca42a7a
0e81c29
a0d70c7
d174bab
77bdab3
3fef23b
1798d7a
bd7c271
6dcfbaf
9942f95
b4ddbbd
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: what happens with this? - does it become part of the workflow definition somewhere? I thought the
Iterator
andItemsPath
properties were required forMap
statesThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ItemsPath is optional. Similar to InputPath and OutputPath, the default is
$
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The iterator is added to the Map State here and will be added to the workflow definition when the Map state itself is added to the workflow definition
The docstring will need to be updated - it seems like
iterator
is required in the Map State constructor when in fact, it gets creates successfully without it. However, the workflow will fail to create if no iterator is set - we could add a validation here and raise an exception if the iterator is not set. At the moment, if fails here with the following messageThis can be done in another PR to avoid making the scope larger