Skip to content

Add "Automatic-Module-Name" to JAR Manifest #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brcolow opened this issue Jul 30, 2021 · 2 comments
Closed

Add "Automatic-Module-Name" to JAR Manifest #292

brcolow opened this issue Jul 30, 2021 · 2 comments

Comments

@brcolow
Copy link
Contributor

brcolow commented Jul 30, 2021

Currently when trying to use aws-xray-sdk-java on a modular Java project one gets the following error:

 (package com.amazonaws.xray.interceptors is declared in the unnamed module, but module my.module does not read it)

Even though this project is not modular you can use the Automatic-Module-Name fallback. Please see:

http://branchandbound.net/blog/java/2017/12/automatic-module-name/

Here is how it is used in AWS aws-sdk-java-v2, for example: https://github.com/aws/aws-sdk-java-v2/search?q=Automatic-Module-Name

Thank you.

@willarmiros
Copy link
Contributor

Hi @brcolow,
I think we'd be open to adding this to support consumers that have modular java projects. If you're able to submit a PR to add this annotation we'd happily take a look!

@brcolow
Copy link
Contributor Author

brcolow commented Aug 3, 2021

Thanks for getting back to me so quickly. Here is the pull request: #295

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants