pynamodb: make the patch compatible with PynamoDB 4 #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #177 +/- ##
==========================================
+ Coverage 83.33% 83.34% +0.01%
==========================================
Files 77 77
Lines 2910 2918 +8
==========================================
+ Hits 2425 2432 +7
- Misses 485 486 +1
Continue to review full report at Codecov.
|
PynamoDB 4.0.0 switches from requests to urllib3 [1], so the patch needs to use another approach for new PynamoDB. Fixes #171 [1] pynamodb/PynamoDB@71c33e8
|
Thank you very much for the PR! I had re-run Travis CI for the latest build and can see that it's failing because PynamoDB is now version 4. Your PR ensures that the tests pass again. We really appreciate the contribution! |
chanchiem
approved these changes
Oct 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#171
Description of changes:
PynamoDB 4.0.0 switches from requests to urllib3 [1], so the patch needs
to use another approach for new PynamoDB.
I've tested this change with PynamoDB 3.4.1 and 4.0.0.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.