Unwrap context provided to psycopg2.extensions.quote_ident #198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #198 +/- ##
==========================================
+ Coverage 83.84% 83.85% +<.01%
==========================================
Files 77 77
Lines 3003 3004 +1
==========================================
+ Hits 2518 2519 +1
Misses 485 485
Continue to review full report at Codecov.
|
|
Thank you very much for your contribution :) |
chanchiem
approved these changes
Jan 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the use of
psycopg2.extensions.quote_identwhen psycopg2 is patched by this SDK. The bug is similar to the one fixed by #95, where a wrapped cursor or connection causes a type error.The new test case gives a minimal example of the bug, which fails against the current master (4689220).
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.