streaming_threshold not None check. Also dropping loop parameter from aiobotocore tests.
#205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es for aiobotocore
…botocore 0.12.0 changes
Codecov Report
@@ Coverage Diff @@
## master #205 +/- ##
==========================================
- Coverage 83.92% 83.54% -0.38%
==========================================
Files 77 77
Lines 3004 2924 -80
==========================================
- Hits 2521 2443 -78
+ Misses 483 481 -2
Continue to review full report at Codecov.
|
bhautikpip
reviewed
Feb 26, 2020
bhautikpip
reviewed
Feb 26, 2020
bhautikpip
reviewed
Mar 3, 2020
tox.ini
Outdated
| @@ -98,4 +98,4 @@ commands = | |||
|
|
|||
| [flake8] | |||
| max-line-length=120 | |||
| exclude=tests | |||
| exclude=tests | |||
There was a problem hiding this comment.
Nit: Can you add a new line here?
srprash
changed the title
loop parameter from aiobotocore tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: 201
Description of changes:
While setting the streaming_threshold in
xray_recorder.configure(), if the value is 0, the condition evaluates to false if not checked for None.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.