Skip to content

add puttracesegments to boto whitelist avoid a catch 22 #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 24, 2020

Conversation

kapilt
Copy link
Contributor

@kapilt kapilt commented Mar 19, 2020

Issue #, if available:
closes #207

Description of changes:
whitelist putting tracesegments to xray to avoid a catch 22 when the segment is closed.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

codecov-io commented Mar 24, 2020

Codecov Report

Merging #210 into master will decrease coverage by 0.06%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #210      +/-   ##
==========================================
- Coverage   84.45%   84.38%   -0.07%     
==========================================
  Files          78       78              
  Lines        3094     3094              
==========================================
- Hits         2613     2611       -2     
- Misses        481      483       +2     
Impacted Files Coverage Δ
aws_xray_sdk/ext/botocore/patch.py 81.25% <0.00%> (ø)
aws_xray_sdk/core/sampling/local/reservoir.py 88.88% <0.00%> (-11.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96134f6...9bf68f6. Read the comment docs.

@shengxil shengxil merged commit 4c9261d into aws:master Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xray sdk with boto patch shouldn't trace itself
3 participants