Skip to content

Added always() to run clean up workflow #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 10, 2020
Merged

Conversation

bhautikpip
Copy link
Contributor

@bhautikpip bhautikpip commented Dec 10, 2020

Issue #, if available:

Description of changes:

cleanup job will run even in the event of test failures.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

codecov-io commented Dec 10, 2020

Codecov Report

Merging #259 (9292a21) into master (f86e7db) will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #259      +/-   ##
==========================================
+ Coverage   79.29%   79.36%   +0.06%     
==========================================
  Files          80       80              
  Lines        3159     3159              
==========================================
+ Hits         2505     2507       +2     
+ Misses        654      652       -2     
Impacted Files Coverage Δ
aws_xray_sdk/core/sampling/local/reservoir.py 100.00% <0.00%> (+11.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f86e7db...9292a21. Read the comment docs.

Copy link
Contributor

@willarmiros willarmiros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bhautikpip bhautikpip merged commit 3c1218e into master Dec 10, 2020
@willarmiros willarmiros deleted the bhautikpip-patch-2 branch November 10, 2021 23:48
Hargrav3s pushed a commit to Gavant/aws-xray-sdk-python that referenced this pull request Mar 22, 2022
* Added `always()` to run clean up workflow

* removed specific version from path

* modified path for cleaning up resources
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants