BugFix: Always close segment in teardown_request handler #272
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #269
Description of changes:
The previous PR which intended to fix the #269 introduced a bug where if the flask application does not pass an exception in case of response code >= 500, the segment will remain unclosed. This may be an edge case scenario that application faults do not pass exception to
teardown_request
handler but it is still a valid case of responses.Thus, irrespective of exception being present or not, the middleware should always end the segment if its present.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.