Enable testing on Python 3.12

[musicinmybrain]

Issue #, if available:

Description of changes:

Added an explicitly dependency on setuptools, since a test imports pkg_resources.

Added Python 3.12 versions of all the tox environments that supported Python 3.11.

Added Python 3.12 to GitHub unit testing workflow.

I did not add Python 3.12 to the trove classifiers, but I’m happy to add this if it’s wanted.

Additional information:

Testing this PR requires #399.

It may also be necessary to use a very recent version of pip:

python3.12 -m venv _e
. _e/bin/activate
pip install --upgrade pip tox
tox

Most tests pass. Some HTTP tests seem to fail or flake in all Python versions due to transient issues at https://httpbin.org/. At a glance, regressions specific to Python 3.12 appear to be due to certain dependencies not being ready.

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[musicinmybrain]

Compare to: #376

[musicinmybrain]

The motivation for this PR is:

• I am adding aws-xray-sdk-python to Fedora Linux, which already has Python 3.12 in the development version (Rawhide) and will release Fedora 39 with Python 3.12 this fall.
• Since test dependencies are generated from (Python-version-specific) tox environments, I needed to patch in Python 3.12 versions of the existing environments to generate the proper dependencies for the RPM build process.
• Offering necessary changes upstream is good practice.

[carolabadeer]

I am still not very clear on why this dependency is needed. You mentioned it was added since a test imports pkg_resources, which test are you referring to?

[musicinmybrain]

https://github.com/aws/aws-xray-sdk-python/blob/2976b25750d04ebe6dc7d0a3e399444896e82cae/tests/test_local_sampling_benchmark.py

Specifically:

aws-xray-sdk-python/tests/test_local_sampling_benchmark.py

Line 3 in 2976b25

from pkg_resources import resource_filename

aws-xray-sdk-python/tests/test_local_sampling_benchmark.py

Line 15 in 2976b25

with open(resource_filename(__name__, 'mock_sampling_rule.json')) as f:

[musicinmybrain]

The pkg_resources module is deprecated, but this test appears to be intentionally and specifically verifying compatibility with it.

[michael-k]

Probably only “necessary” on Python 3.12 though:

gh-95299: Do not pre-install setuptools in virtual environments created with venv. This means that distutils, setuptools, pkg_resources, and easy_install will no longer available by default; to access these run pip install setuptools in the activated virtual environment.

https://docs.python.org/3.12/whatsnew/3.12.html

[musicinmybrain]

Perhaps, but it’s not harmful on others. The dependency is still real; it’s just allowed to be implicit. I guess I can change to py312 only if implicit is better than explicit.

[michael-k]

FYI: Should have worked at the time with 3.12.0-beta - 3.12. But it's available now, see https://github.com/actions/python-versions/blob/main/versions-manifest.json

Maybe rebase to trigger a rerun?

[musicinmybrain]

Hmm, I’m not sure why this is failing on Python 3.12 with ModuleNotFoundError: No module named 'setuptools' from setup.py. In local testing with tox, the added dependency on setuptools in tox.ini works as expected.

[michael-k]

run: pip install "tox<=3.27.1" -U tox-factor should install setuptools as well. The added dependency is only available inside the venv that tox creates. But it's required outside as well to build the sdist.

aws-xray-sdk-python/.github/workflows/UnitTesting.yaml

Lines 42 to 43 in 8563afc

	- name: Install tox
	run: pip install "tox<=3.27.1" -U tox-factor

[musicinmybrain]

run: pip install "tox<=3.27.1" -U tox-factor should install setuptools as well. The added dependency is only available inside the venv that tox creates. But it's required outside as well to build the sdist.

Thanks. Hopefully 2a682c9 is correct and sufficient.