Updated XRaySessionMaker constructor to follow SQLAlchemy's implementation #454
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
I tested with the following version:
Running the above code results in the following error:
The XRaySessionMaker constructor acts as a wrapper around sqlalchemy.orm.session.sessionmaker's constructor.
However, the sessionmaker constructor expects keyword-only arguments, while XRaySessionMaker is calling it with positional arguments, resulting in an error
https://github.com/aws/aws-xray-sdk-python/blob/2.14.0/aws_xray_sdk/ext/sqlalchemy/query.py#L24-L25
https://github.com/zzzeek/sqlalchemy/blob/rel_2_0_38/lib/sqlalchemy/orm/session.py#L5042-L5050
Accordingly, I updated the call to use keyword arguments.
I have verified that tracing works correctly after applying this fix.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.