Removing Entity Name invalid characters #8
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haotianw465
suggested changes
Dec 1, 2017
aws_xray_sdk/core/models/entity.py
Outdated
| @@ -12,21 +13,26 @@ | |||
|
|
|||
|
|
|||
| log = logging.getLogger(__name__) | |||
| _valid_name_characters = string.ascii_letters + string.digits + '_.:/%&#=+\-@' | |||
There was a problem hiding this comment.
It would be useful to add the doc link here as a comment for future reference.
aws_xray_sdk/core/models/entity.py
Outdated
| self.start_time = time.time() | ||
| self.parent_id = None | ||
|
|
||
| if self.name != name: | ||
| log.warning("Removing Name invalid characters.") |
There was a problem hiding this comment.
Use segment/subsegment name instead of name could be clearer when user see such log entries.
Add support for aiobotocore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you create subsegments with invalid Name characters, this causes issues in the X-Ray traces. This Pull Request remove the invalid characters and adds a warning in the log. The valid character list has been found on http://docs.aws.amazon.com/xray/latest/devguide/xray-api-segmentdocuments.html.