fix: Changes to address the field name error: json shadows a BaseModel attribute #270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsareddy0329
requested a deployment
to
manual-approval
GitHub Actions
Waiting
nargokul
reviewed
Mar 27, 2025
Comment on lines
30862
to
30866
| "Json":{ | ||
| "JsonFormat":{ | ||
| "shape":"MonitoringJsonDatasetFormat", | ||
| "documentation":"<p>The JSON dataset used in the monitoring job</p>" | ||
| "documentation":"<p>The JSON dataset used in the monitoring job</p>", | ||
| "alias": "json" | ||
| }, |
There was a problem hiding this comment.
SO this is going to get overridden on the next botocore sync .
I think we should handle this condition in codegen engine
There was a problem hiding this comment.
Yes, this is handled in the codegen as well.
Updated the service json and shapes_extractor and shapes_codegen accordingly.
This file was generated using the codegen run in local.
rsareddy0329
requested a deployment
to
manual-approval
GitHub Actions
Waiting
rsareddy0329
requested a deployment
to
manual-approval
GitHub Actions
Waiting
…BaseModel attribute
rsareddy0329
requested a deployment
to
manual-approval
GitHub Actions
Waiting
…BaseModel attribute
rsareddy0329
temporarily deployed
to
manual-approval
GitHub Actions
Inactive
nargokul
approved these changes
Mar 27, 2025
rsareddy0329
temporarily deployed
to
manual-approval
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
aws/sagemaker-python-sdk#4944
Description of changes:
Error details:
NameError: Field name "json" shadows a BaseModel attribute; use a different field name with "alias='json'"Updated the shapes codegen scripts and service json file to handle the "alias" if included in a structure field type.
Test
pytest tstfrom sagemaker.jumpstart.types import JumpStartLaunchedRegionInfoBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.